833855 - [SMS] When taping to view a conversation of 100 messages, the app does nothing for 6sec before showing the conversation screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Etienne Segonzac (:etienne)]

We know the current solution of fetching all the message from one contact at once doesn't scale well, and we have plans to resolve this (see bug 806592 dependencies).

But in the meantime we could at least give the user some visual cue that the conversation is loading, the current experience is borderline dogfood-blocker.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Patch proposal

With this patch we animate the slide to the "conversation" panel as soon as a conversation is selected. Then load and render the messages as fast as possible.

We could easily add a spinner of some sort if it makes sense to the UX team.

Comment 2

[David Scravaglieri [:scravag]]

We would take a patch for this

Comment 3

[Borja Salguero [:borjasalguero]]

Attachment: Small fix to the patch for Keyboard

Comment 4

[Borja Salguero [:borjasalguero]]

Hi Etienne! The code looks nice, but there is a weird behaviour in transition when keyboard is shown. I've uploaded a small patch to your patch fot fixing this issue. Please add this code and for me it's ok! Let me know when you have the final patch for reviewing.

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Right fix for keyboard issue

Comment 6

[Borja Salguero [:borjasalguero]]

The right one is https://bug833855.bugzilla.mozilla.org/attachment.cgi?id=705783 ;)

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Even better patch to Keyboard issue

Comment 8

[Borja Salguero [:borjasalguero]]

Updated the patch properly.

Comment 10

[Borja Salguero [:borjasalguero]]

This one should be tef+ due to the bug related with the 'loading-time' of a conversation it's fixed by the patch. However, https://bugzilla.mozilla.org/show_bug.cgi?id=827815 it's a 'optimization/polish', so that one should be nominated as 	tracking-b2g18+ (overall because that patch will be based on this one).

Comment 11

[Etienne Segonzac (:etienne)]

Attachment: Patch v2

Patch updated with the smooth transition back when the keyboard is displayed.

Comment 12

[Etienne Segonzac (:etienne)]

landed on master

https://github.com/mozilla-b2g/gaia/commit/0f2448ef3db1d9179be8fe12891c0abb487d4c52

Comment 13

[Walter Chen[:ypwalter][:wachen]]

Attachment: sms gaia-ui-test script for 100 sms

I tested this in pvt b2g18 user build.

Gaia:
  Rev     7cacbcb8042b49d816a34de8e9767dcedefa6d84
  B-D     2013-01-25 02:57:10
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/32c2cc3e19ff
BuildID   20130124140859
Version   18.0

I tried to send 100 sms. However, it still took 4 sec for 100 2-line messages. I don't think it improve a lot.

attached the script of gaia-ui-test
(please change the number before you start it.)

Comment 14

[Walter Chen[:ypwalter][:wachen]]

I don't know if this is a valid fix. Leave this for other QAs to judge

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to Walter Chen from comment #14)
> I don't know if this is a valid fix. Leave this for other QAs to judge

The long term plan is not to load all the message of the conversation and have some sort of pagination.
Since this require a new UX, new visuals, and more dev it wasn't doable for this milestone.

This patch's goal is to start the transition between the thread list and the conversation right away to give the user visual feedback.

Feel free to update the summary, but the app now shows the conversation screen right away (and then loads the conversation).

Comment 16

[Walter Chen[:ypwalter][:wachen]]

OK.

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Etienne Segonzac (:etienne) from comment #15)
> (In reply to Walter Chen from comment #14)
> > I don't know if this is a valid fix. Leave this for other QAs to judge
> 
> The long term plan is not to load all the message of the conversation and
> have some sort of pagination.
> Since this require a new UX, new visuals, and more dev it wasn't doable for
> this milestone.

Can you explain this in more detail?  Why is new UX, visuals, etc needed?

Short of that, why can't we just load messages into the UI in chunks to give better responsiveness?  That is, load most recent 10, repaint, (load other messages chunked).

Comment 18

[Etienne Segonzac (:etienne)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #17)
> (In reply to Etienne Segonzac (:etienne) from comment #15)
> > (In reply to Walter Chen from comment #14)
> > > I don't know if this is a valid fix. Leave this for other QAs to judge
> > 
> > The long term plan is not to load all the message of the conversation and
> > have some sort of pagination.
> > Since this require a new UX, new visuals, and more dev it wasn't doable for
> > this milestone.
> 
> Can you explain this in more detail?  Why is new UX, visuals, etc needed?

Don't know the details, but I'm guessing a "load more" button if you scroll all the way up, or a "pull dowan to load more"...

> Short of that, why can't we just load messages into the UI in chunks to give
> better responsiveness?  That is, load most recent 10, repaint, (load other
> messages chunked).

This is a really good idea, I don't see why we can't :)
Filed bug 834895.